c2_pro help needed with indicator lights

[Vasja1986]

Issue Description

I have a c2 pro rgb keyboard. When compiling the default keymap for this keyboard and subsequently flashing the compiled code into the keyboard, the indicator lights (num, caps, mac, win) do not show the right indications, instead they are flashing with a pattern that follows the rgb matrix. How can i get the indicator lights behave like in the default factory firmware, i.e. caps only lights when caps lock is activated etc?

[PeterMortensen]

Does it work when the RGB animation mode is static ("solid colour")?

[PeterMortensen]

Re "they are flashing with a pattern that follows the RGB matrix": Can you elaborate? What happens when doing specific actions? What actions? Can you provide an example? In what RGB animation mode?

[Vasja1986]

I put the following in my rules.mk

SRC += matrix.c
RGB_MATRIX_ENABLE = yes
RGB_MATRIX_SOLID_COLOR = yes
KEYBOARD_SHARED_EP = yes

While doing so, the animation still occurs, instead of displaying a solid color.
If i set RGB_MATRIX_ENABLE to no, then no lights are enabled at all.

[Vasja1986]

Re "they are flashing with a pattern that follows the RGB matrix": Can you elaborate? What happens when doing specific actions? What actions? Can you provide an example? In what RGB animation mode?

It does not respond to any actions. The default animation (whatever that is) gets displayed if RGB_MATRIX is enabled and does not react to input.

[Vasja1986]

Turns out the problem is in qmk_firmware/tree/master/keyboards/keychron/c2_pro/c2_pro.c

the indicator code is commented out if LED_MATRIX_ENABLE is not defined, which is the case for the rgb variant of the keyboard. The last #endif should be moved up some place before bool process_record_kb.

[rant]Great waste of time. Excellent quality control.[/rant]

[Vasja1986]

@KeychronMacro @drashna @adophoxia @waffle87

You guys have authored the following commit: qmk@ecca9c5

Unfortunately a preprocessor directive was placed in the incorrect place, which causes the indicator lights of the rgb version of this keyboard to malfunction. Please refer to this thread for details.