Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] BLE Advertising Battery Level #338

Open
2 of 4 tasks
spit4520 opened this issue Dec 3, 2024 · 2 comments
Open
2 of 4 tasks

[Feature Request] BLE Advertising Battery Level #338

spit4520 opened this issue Dec 3, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@spit4520
Copy link

spit4520 commented Dec 3, 2024

Feature Request Type

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

Hello,

I have the Keychron K10 Pro, and I love it. I would love it if I could submit a PR with the necessary changes to expose the the proper GATT service for the Battery Level. I have been writing automotive, infotainment, and embedded for for 10 years and I am willing to donate the feature. If you could please let me know if this is the correct repository so submit the PR, and give me the specifications you would require in order to merge this upstream, then I can get started. I understand that battery life could be a concern, so if you could provide your internal product goals on the refresh interval for the advertisement then I can make sure the PR is compliant.

I've loved my Keychron and this is the only feature that I have found in the last year that has been missing, you are doing a wonderful job and I'd love to volunteer to keep the ball rolling

Best,

S.Joseph

@spit4520 spit4520 added enhancement New feature or request help wanted Extra attention is needed labels Dec 3, 2024
@PeterMortensen
Copy link

Presuming it is the same thing, it works for the V6 Max (presumably the whole V Max series. And probably also the K Max and Q Max series).

Proof.

But not for the K Pro series in the same setup.

Presumably, they use different Bluetooth modules. I don't know if this has anything to do with it.

@bam80
Copy link

bam80 commented Dec 13, 2024

But not for the K Pro series in the same setup.

Might be related, please confirm:
#341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants