Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS - Crash when Color Picker is used #26

Open
KeziahMoselle opened this issue Oct 12, 2018 · 7 comments
Open

MacOS - Crash when Color Picker is used #26

KeziahMoselle opened this issue Oct 12, 2018 · 7 comments
Assignees
@Shiroifuyu
Labels
bug Something isn't working

Comments

@KeziahMoselle
Copy link
Owner

No description provided.

@KeziahMoselle KeziahMoselle added the bug Something isn't working label Oct 12, 2018
@Shiroifuyu
Copy link
Collaborator

I'm working on this, do you have any MacOS to try the fix on?

@KeziahMoselle
Copy link
Owner Author

Yes I can ! Thank's for trying 🎉

@Shiroifuyu
Copy link
Collaborator

Just revised everything, it seems like the implementation is correct.
So we have two options, investigate more about the crash or pick another method for color picking.

@KeziahMoselle
Copy link
Owner Author

Here is a preview of the issue :
preview.gif

@KeziahMoselle
Copy link
Owner Author

Read the code too and I can't find any potential error. We are not supporting MacOS and Linux for the moment so it's not a big deal in my opinion, we can try to fix this later 👍

@Shiroifuyu
Copy link
Collaborator

I'm reading about it, seems like an Electron's error, a lot of issues on MacOS with Electron when using colorpicker.

@KeziahMoselle
Copy link
Owner Author

Mmh alright, I will report our error in the issue then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shiroifuyu Shiroifuyu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KeziahMoselle @Shiroifuyu