Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to be made #2

Open
kvmanohar22 opened this issue Nov 8, 2017 · 0 comments
Open

Changes to be made #2

kvmanohar22 opened this issue Nov 8, 2017 · 0 comments

Comments

@kvmanohar22
Copy link
Contributor

I think we need to make certain changes to the data types that are used in the planner.

  1. Instead of using
typedef struct 
{
  double x;
  double y;
}point;

it would be better if we use the point from krssg_ssl_msgs msg package (point_2d).

  1. Currently, the planner is only accepting the points from the GUI, we need to change this so that skills are able to call.
Planning(std::vector<pos> &v,int n, gui_msg gui_msgs);
  1. It's better if we start using the data types from krssg_ssl_msgs, in that way we don't need to define them wherever we start using. The following data types which are currently defined in MotionPlanner.h
typedef struct 
{
  double x;
  double y;
}point;

typedef struct 
{
  double stepSize;
  double maxIteration;
  double biasParam;
  int planner_selector;
}gui_msg;

typedef struct {
  double xrange[2];
  double yrange[2];
} RANGE;

typedef struct
{
    double x;
    double y;
}pos;
  1. In addition, it would be better if we define following method in Planner.
bool should_replan();

@KgpKubs/path any more ideas, please add them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant