From b5ed60f061fc2f2627c3167ad2f36adeba67c509 Mon Sep 17 00:00:00 2001 From: Kai Ingo Esser Date: Sat, 20 Mar 2021 11:18:00 +0100 Subject: [PATCH 1/3] Add header include This project compiles by chance because the header "openxr_reflection.h" was included before the #include "common.h". --- src/tests/hello_xr/common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/tests/hello_xr/common.h b/src/tests/hello_xr/common.h index a53bb5235..5151495ec 100644 --- a/src/tests/hello_xr/common.h +++ b/src/tests/hello_xr/common.h @@ -10,6 +10,8 @@ #include #include +#include "openxr_reflection.h" + // Macro to generate stringify functions for OpenXR enumerations based data provided in openxr_reflection.h // clang-format off #define ENUM_CASE_STR(name, val) case name: return #name; From 92275c286ccffede7581b59f56f1cee19791e532 Mon Sep 17 00:00:00 2001 From: Kai Ingo Esser Date: Mon, 22 Mar 2021 11:05:35 +0100 Subject: [PATCH 2/3] Update common.h --- src/tests/hello_xr/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/hello_xr/common.h b/src/tests/hello_xr/common.h index 5151495ec..3ab84931f 100644 --- a/src/tests/hello_xr/common.h +++ b/src/tests/hello_xr/common.h @@ -10,7 +10,7 @@ #include #include -#include "openxr_reflection.h" +#include // Macro to generate stringify functions for OpenXR enumerations based data provided in openxr_reflection.h // clang-format off From 0ba2bb95532b526795e4edf6331c0ce41b623365 Mon Sep 17 00:00:00 2001 From: Ryan Pavlik Date: Fri, 2 Apr 2021 09:14:00 -0500 Subject: [PATCH 3/3] Add changelog fragment --- changes/sdk/pr.247.gh.OpenXR-SDK-Source.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 changes/sdk/pr.247.gh.OpenXR-SDK-Source.md diff --git a/changes/sdk/pr.247.gh.OpenXR-SDK-Source.md b/changes/sdk/pr.247.gh.OpenXR-SDK-Source.md new file mode 100644 index 000000000..070af0da6 --- /dev/null +++ b/changes/sdk/pr.247.gh.OpenXR-SDK-Source.md @@ -0,0 +1 @@ +hello_xr: Make sure `common.h` includes the reflection header that it uses.