Add ByteAddressBuffer support #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoticbob
reviewed
Jan 10, 2024
| uint32_t uav_counter_id; | ||
| struct SpvReflectDescriptorBinding* uav_counter_binding; | ||
|
|
||
| SpvReflectTypeDescription* type_description; | ||
|
|
||
| uint32_t is_byte_address_buffer; |
There was a problem hiding this comment.
We should find some way to make this a flag so it can be used to identify other concrete types. ByteAddressBuffer is a concrete type on an SRV and there are a few others like it.
There was a problem hiding this comment.
sorry this is old (about to replace with new PR)
I created a
typedef enum SpvReflectUserType {
SPV_REFLECT_USER_TYPE_INVALID = 0,
SPV_REFLECT_USER_TYPE_CBUFFER,
SPV_REFLECT_USER_TYPE_TBUFFER,
SPV_REFLECT_USER_TYPE_APPEND_STRUCTURED_BUFFER,
...
so this becomes an enum... basically will be a more general approach, this PR is too single focused to solve one task
|
closed for #248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prototype for #234