Work on more general solution to adding access chain placeholders during reduction #2183
Labels
Comments
dneto0
pushed a commit
to dneto0/SPIRV-Tools
that referenced
this issue
Sep 14, 2024
Roll third_party/effcee/ 98980e2b7..5af957bbf (1 commit) google/effcee@98980e2...5af957b $ git log 98980e2b7..5af957bbf --date=short --no-merges --format='%ad %ae %s' 2019-12-20 raj.khem Respect CMAKE_INSTALL_LIBDIR in installed CMake files Roll third_party/glslang/ 4d2298b..3f4e5c4 (2 commits) KhronosGroup/glslang@4d2298b...3f4e5c4 $ git log 4d2298b..3f4e5c4 --date=short --no-merges --format='%ad %ae %s' 2020-04-19 63069047+pmistryNV Add support for extension GL_ARB_shader_image_size (KhronosGroup#2185) 2020-04-17 63069047+pmistryNV Add support for extension GL_ARB_shader_bit_encoding (KhronosGroup#2183) Roll third_party/googletest/ e3f0319d8..dcc92d0ab (7 commits) google/googletest@e3f0319...dcc92d0 $ git log e3f0319d8..dcc92d0ab --date=short --no-merges --format='%ad %ae %s' 2020-04-10 absl-team Googletest export 2020-04-12 jbohl fix signed/unsigned comparison issue (on OpenBSD) 2020-04-09 malcolm.parsons Remove redundant .c_str() 2020-04-06 mail gtest-unittest-api_test - fix warning in clang build 2020-03-28 arthur.j.odwyer Replace the last instance of `throw()` with `noexcept`. NFC. 2020-03-28 arthur.j.odwyer Fix a typo in .travis.yml 2020-03-21 ngompa13 Ensure that gtest/gmock pkgconfig requirements specify version Roll third_party/re2/ ac65d4531..a5c78ae3e (1 commit) google/re2@ac65d45...a5c78ae $ git log ac65d4531..a5c78ae3e --date=short --no-merges --format='%ad %ae %s' 2020-04-19 junyer Use 64-bit integers for the BitState bitmap. Roll third_party/spirv-cross/ 54658d625..f38cbeb81 (4 commits) KhronosGroup/SPIRV-Cross@54658d6...f38cbeb $ git log 54658d625..f38cbeb81 --date=short --no-merges --format='%ad %ae %s' 2020-04-20 post MSL: Allow removing clip distance user varyings. 2020-04-18 godlike Reflection: Add specialization constant name 2020-04-15 cdavis MSL: Force disabled fragment builtins to have the right name. 2020-04-15 cdavis MSL: Only disable output variables in fragment shaders. Roll third_party/spirv-tools/ ca57515..61b7de3 (10 commits) KhronosGroup/SPIRV-Tools@ca57515...61b7de3 $ git log ca57515..61b7de3 --date=short --no-merges --format='%ad %ae %s' 2020-04-15 stevenperron Remove unreachable code. (KhronosGroup#3304) 2020-04-15 afdx spirv-fuzz: Fix to outliner (KhronosGroup#3302) 2020-04-14 afdx spirv-fuzz: Do not outline regions that produce pointer outputs (KhronosGroup#3291) 2020-04-14 afdx spirv-fuzz: Handle OpRuntimeArray when replacing ids with synonyms (KhronosGroup#3292) 2020-04-14 afdx spirv-fuzz: Handle image storage class in donation (KhronosGroup#3290) 2020-04-14 afdx spirv-fuzz: Respect rules for OpSampledImage (KhronosGroup#3287) 2020-04-14 afdx spirv-fuzz: Fix comment. (KhronosGroup#3300) 2020-04-14 stevenperron Sampled images as read-only storage (KhronosGroup#3295) 2020-04-14 alanbaker Remove implicit fallthrough (KhronosGroup#3298) 2020-04-14 stevenperron Add tests for recently added command line option (KhronosGroup#3297) Created with: roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In spirv-reduce's loop-to-conditional reduction pass, if we find that an access chain use is no longer dominated, we replace the use with an access to a (possibly new) variable of the right type. This is fine if the storage class is Private or Function; we can just add a new variable. But for other storage classes I'm unsure whether it's legal to arbitrarily add more global-scoped variables with the given storage class; there might be limits on the number of such variables that are allowed, and quite possibly constraints on adding such variables without modifying the associated host code.
The text was updated successfully, but these errors were encountered: