Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make spvOpcodeString() part of the public API #3138

Closed
c0d1f1ed opened this issue Jan 15, 2020 · 1 comment · Fixed by #3174
Closed

Make spvOpcodeString() part of the public API #3138

c0d1f1ed opened this issue Jan 15, 2020 · 1 comment · Fixed by #3174
Assignees
@s-perron

Comments

@c0d1f1ed
Copy link
Contributor

In https://swiftshader-review.googlesource.com/c/SwiftShader/+/38820 we added a forward declaration of spvOpcodeString() to our code base. Adding it to the public API of SPIRV-Tools would allow it to be used more widely and help avoid breakage.
@dneto0
Copy link
Collaborator

dneto0 commented Jan 30, 2020

Sending to @s-perron

This API and its implementation is stateless (doesn't need a spv_context), so we can expose this
with little work. The comment on the method has to say that it assumes the opcode is valid, based on the spirv.core.grammar.json used when building SPIRV-Tools. (At the moment it otherwise asserts out in a debug build.)

s-perron added a commit to s-perron/SPIRV-Tools that referenced this issue Feb 4, 2020
@s-perron
Make spvOpcodeString part of the public API
9025b8f 
Fixes KhronosGroup#3138
s-perron added a commit to s-perron/SPIRV-Tools that referenced this issue Feb 4, 2020
@s-perron
Make spvOpcodeString part of the public API
9867574 
Fixes KhronosGroup#3138
@s-perron s-perron mentioned this issue Feb 4, 2020
Merged
s-perron added a commit to s-perron/SPIRV-Tools that referenced this issue Feb 20, 2020
@s-perron
Make spvOpcodeString part of the public API
7a1ce7b 
Fixes KhronosGroup#3138
s-perron added a commit that referenced this issue Feb 20, 2020
@s-perron
Make spvOpcodeString part of the public API (#3174)
4a80497 
Fixes #3138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s-perron s-perron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make spvOpcodeString part of the public API s-perron/SPIRV-Tools
3 participants
@c0d1f1ed @dneto0 @s-perron