Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCL.DebugInfo.100 information preservation in spirv-opt legalization passes #3386

Closed
19 tasks done
jaebaek opened this issue Jun 1, 2020 · 8 comments
Closed
19 tasks done

Comments

@jaebaek
Copy link
Contributor

jaebaek commented Jun 1, 2020

This is an umbrella bug for OpenCL.DebugInfo.100 information preservation in spirv-opt legalization passes. #3367 and #3366 are parts of the debug information preservation.

  • wrap-opkill
  • eliminate-dead-branches
  • merge-return
  • inline-entry-points-exhaustive
  • eliminate-dead-functions
  • private-to-local
  • fix-storage-class
  • eliminate-local-single-block
  • eliminate-local-single-store
  • eliminate-dead-code-aggressive
  • scalar-replacement=0
  • ssa-rewrite
  • ccp
  • loop-unroll
  • simplify-instructions
  • copy-propagate-arrays
  • vector-dce
  • eliminate-dead-inserts
  • reduce-load-size
@jaebaek
Copy link
Contributor Author

jaebaek commented Jun 1, 2020

@jaebaek
Copy link
Contributor Author

jaebaek commented Jun 1, 2020

Related spirv-val PRs: #3133 #3104 #3374

We have to add the validation for more OpenCL.DebugInfo.100 instructions: #3369

@jaebaek
Copy link
Contributor Author

jaebaek commented Jun 1, 2020

ssa-rewrite is WIP: #3356

@greg-lunarg
Copy link
Contributor

greg-lunarg commented Jun 1, 2020

I will start with eliminate-local-single-block and eliminate-local-single-store.

@jaebaek
Copy link
Contributor Author

jaebaek commented Jun 1, 2020

I just sent a PR for merge return pass: #3389

@jaebaek
Copy link
Contributor Author

jaebaek commented Jun 2, 2020

I created this kanban to easily check the progress: https://github.com/KhronosGroup/SPIRV-Tools/projects/6

@jaebaek
Copy link
Contributor Author

jaebaek commented Jul 21, 2020

For the fix-storage-class pass, we do not have to update the code for the debug information because it does not have any impact on the debug information.

@jaebaek
Copy link
Contributor Author

jaebaek commented Aug 12, 2020

The debug info preservation in the spirv-opt legalization passes is done \o/

@jaebaek jaebaek closed this as completed Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants