Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spirv-val: Add support for SPV_AMD_shader_image_load_store_lod #3186

Merged
merged 2 commits into from
Feb 18, 2020
Merged

spirv-val: Add support for SPV_AMD_shader_image_load_store_lod #3186

merged 2 commits into from
Feb 18, 2020

Conversation

samuelig
Copy link
Contributor

According to SPV_AMD_shader_image_load_store_lod spec, Lod operand is
valid with OpImageRead, OpImageWrite, or OpImageSparseRead if the
extension is enabled.

@claassistantio
Copy link

claassistantio commented Feb 12, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

alan-baker
alan-baker requested changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add tests for sparse read.

source/val/validation_state.h Outdated Show resolved Hide resolved
@samuelig
spirv-val: Add support for SPV_AMD_shader_image_load_store_lod
0bdf278 
According to SPV_AMD_shader_image_load_store_lod spec, Lod operand is
valid with OpImageRead, OpImageWrite, or OpImageSparseRead if the
extension is enabled.
@samuelig samuelig force-pushed the SPV_AMD_shader_image_load_store_lod branch from a2845c2 to 0bdf278 Compare February 14, 2020 07:42
@samuelig samuelig requested a review from alan-baker February 14, 2020 07:57
@samuelig
Copy link
Contributor Author

CI-shaderc-smoketest check is failing because glslang expects a validation failure on a SPV_AMD_shader_image_load_store_lod test . I have a fix here.

Should I land glslang fix first for review? Or land this first and then the glslang fix? Which is the procedure for this case?

@samuelig samuelig mentioned this pull request Feb 18, 2020
Merged
@samuelig
Copy link
Contributor Author

CI-shaderc-smoketest check is failing because glslang expects a validation failure on a SPV_AMD_shader_image_load_store_lod test . I have a fix here.

Should I land glslang fix first for review? Or land this first and then the glslang fix? Which is the procedure for this case?

Glslang pull request: KhronosGroup/glslang#2086

@alan-baker alan-baker merged commit 4d912f4 into KhronosGroup:master Feb 18, 2020
dneto0 pushed a commit to dneto0/SPIRV-Tools that referenced this pull request Sep 14, 2024
@zoddicus
Rolling 6 dependencies and update expectations (KhronosGroup#987)
1059f43 
Roll third_party/glslang/ 5e86b28..c12493f (10 commits)

KhronosGroup/glslang@5e86b28...c12493f

$ git log 5e86b28..c12493f --date=short --no-merges --format='%ad %ae %s'
2020-02-17 siglesias SPV_AMD_shader_image_load_store_lod is now validated by spirv-tools
2020-02-19 lryer Fix iomapper issue
2020-02-11 cepheus Fix part of KhronosGroup#2070: Correctly handle promotion for <unary-op>(int).
2020-02-18 swda.durl Add an option to make RTTI enabled
2020-02-06 kainino Split "is emscripten" config from "enable glslang.js"
2020-02-06 dneto Avoid enum-compare warning
2020-02-06 rex.xu Fix a parser error of GL_KHR_memory_scope_semantics
2020-01-23 kainino glslang.js: Make the SPIR-V target version configurable (1.0 ~ 1.5)
2020-02-02 timo.suoranta Fix memory corruption in TGlslIoMapper
2019-12-23 laddoc Add constant expression with mod

Roll third_party/googletest/ 10b1902d8..23b2a3b1c (21 commits)

google/googletest@10b1902...23b2a3b

$ git log 10b1902d8..23b2a3b1c --date=short --no-merges --format='%ad %ae %s'
2020-02-12 absl-team Googletest export
2020-02-11 absl-team Googletest export
2020-02-11 absl-team Googletest export
2020-02-10 absl-team Googletest export
2020-02-10 absl-team Googletest export
2020-02-07 absl-team Googletest export
2020-02-07 absl-team Googletest export
2020-02-06 durandal Googletest export
2020-02-05 absl-team Googletest export
2020-02-05 absl-team Googletest export
2020-02-03 absl-team Googletest export
2020-02-03 absl-team Googletest export
2020-01-31 absl-team Googletest export
2020-01-31 absl-team Googletest export
2020-01-29 absl-team Googletest export
2020-01-27 absl-team Googletest export
2020-01-27 absl-team Googletest export
2020-01-27 absl-team Googletest export
2020-01-24 absl-team Googletest export
2020-01-24 absl-team Googletest export
2020-01-23 absl-team Googletest export

Roll third_party/re2/ 05faa8db3..793b4e85e (10 commits)

google/re2@05faa8d...793b4e8

$ git log 05faa8db3..793b4e85e --date=short --no-merges --format='%ad %ae %s'
2020-02-17 junyer Move DeBruijnString() alongside StringGenerator.
2020-02-14 junyer Fix the check for Apple platforms. Mea culpa.
2020-02-14 junyer Provide hooks::context iff thread_local is supported.
2020-02-14 junyer Update doc/syntax.html.
2020-02-13 junyer MSVC also doesn't like casting lambdas with `+'. Sigh.
2020-02-13 junyer Only the latest MSVC allows designated initalisers.
2020-02-13 junyer Provide instrumentation points called "hooks".
2020-02-11 junyer Tidy up some GCC-only guards.
2020-02-04 junyer Tidy up the SWIG guard around LazyRE2.
2020-02-03 junyer Tweak some of the comments about FilteredRE2.

Roll third_party/spirv-cross/ 6b2add8e2..f19fdb94d (4 commits)

KhronosGroup/SPIRV-Cross@6b2add8...f19fdb9

$ git log 6b2add8e2..f19fdb94d --date=short --no-merges --format='%ad %ae %s'
2020-02-19 dsinclair Roll GLSLang, SPIRV-Tools and SPIRV-Headers
2020-02-14 post Reject SPIR-V modules with garbage ID bound.
2020-02-08 post HLSL: Declare undef variables as static.
2020-02-06 post Remove old memory_scope flag from iOS barriers.

Roll third_party/spirv-headers/ dc77030..5dbc1c3 (1 commit)

KhronosGroup/SPIRV-Headers@dc77030...5dbc1c3

$ git log dc77030..5dbc1c3 --date=short --no-merges --format='%ad %ae %s'
2020-02-07 michael.kinsner Allocate three bits for upcoming Intel extension

Roll third_party/spirv-tools/ ddcc117..4a80497 (19 commits)

KhronosGroup/SPIRV-Tools@ddcc117...4a80497

$ git log ddcc117..4a80497 --date=short --no-merges --format='%ad %ae %s'
2020-02-20 stevenperron Make spvOpcodeString part of the public API (KhronosGroup#3174)
2020-02-20 danyspin97 Fix static libraries linking order (KhronosGroup#3189)
2020-02-18 bclayton vscode: Add missing fields to schema.Opcode (KhronosGroup#3169)
2020-02-18 siglesias spirv-val: Add support for SPV_AMD_shader_image_load_store_lod (KhronosGroup#3186)
2020-02-14 afdx spirvfuzz: Fix type-related bug, change undef to zero, and add assert (KhronosGroup#3188)
2020-02-11 afdx spirv-fuzz: Fuzzer pass that adds access chains (KhronosGroup#3182)
2020-02-10 afdx spirv-fuzz: Fuzzer pass to add function calls (KhronosGroup#3178)
2020-02-10 afdx spirv-fuzz: Ensure that donated variables are always initialized (KhronosGroup#3181)
2020-02-06 afdx spirv-fuzz: Add fuzzer passes to add loads/stores (KhronosGroup#3176)
2020-02-05 afdx spirv-fuzz: Fuzzer passes to add local and global variables (KhronosGroup#3175)
2020-02-04 bclayton utils/vscode: LSP - Support OpExtInst (KhronosGroup#3140)
2020-02-04 kubak Fix typos in opt's help. Update environment version. (KhronosGroup#3170)
2020-02-04 stevenperron Start SPIRV-Tools v2020.2
2020-02-04 stevenperron Finalize SPIRV-Tools v2020.1
2020-02-04 stevenperron Update CHANGES
2020-02-04 afdx spirv-fuzz: Fuzzer pass to add composite types (KhronosGroup#3171)
2020-02-04 afdx Update script that checks copyright years. (KhronosGroup#3173)
2020-02-04 afdx spirv-fuzz: Disallow copying of null and undefined pointers (KhronosGroup#3172)
2020-02-03 dnovillo Handle TimeAMD in AmdExtensionToKhrPass. (KhronosGroup#3168)

Created with:
  roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-baker alan-baker alan-baker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuelig @claassistantio @alan-baker @kokoro-team