Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit fallthrough #3298

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Remove implicit fallthrough #3298

merged 1 commit into from
Apr 14, 2020

Conversation

alan-baker
Copy link
Contributor

Fixes #3296

  • Make OpReturn its own case fully

@alan-baker
Remove implicit fallthrough
53d377c 
Fixes KhronosGroup#3296

* Make OpReturn its own case fully
@alan-baker alan-baker requested a review from s-perron April 14, 2020 12:36
@alan-baker alan-baker self-assigned this Apr 14, 2020
@s-perron s-perron merged commit 2a2bdbd into KhronosGroup:master Apr 14, 2020
dneto0 pushed a commit to dneto0/SPIRV-Tools that referenced this pull request Sep 14, 2024
@zoddicus
Rolling 6 dependencies and update expectations (KhronosGroup#1047)
6385961 
Roll third_party/effcee/ 98980e2b7..5af957bbf (1 commit)

google/effcee@98980e2...5af957b

$ git log 98980e2b7..5af957bbf --date=short --no-merges --format='%ad %ae %s'
2019-12-20 raj.khem Respect CMAKE_INSTALL_LIBDIR in installed CMake files

Roll third_party/glslang/ 4d2298b..3f4e5c4 (2 commits)

KhronosGroup/glslang@4d2298b...3f4e5c4

$ git log 4d2298b..3f4e5c4 --date=short --no-merges --format='%ad %ae %s'
2020-04-19 63069047+pmistryNV Add support for extension GL_ARB_shader_image_size (KhronosGroup#2185)
2020-04-17 63069047+pmistryNV Add support for extension GL_ARB_shader_bit_encoding (KhronosGroup#2183)

Roll third_party/googletest/ e3f0319d8..dcc92d0ab (7 commits)

google/googletest@e3f0319...dcc92d0

$ git log e3f0319d8..dcc92d0ab --date=short --no-merges --format='%ad %ae %s'
2020-04-10 absl-team Googletest export
2020-04-12 jbohl fix signed/unsigned comparison issue (on OpenBSD)
2020-04-09 malcolm.parsons Remove redundant .c_str()
2020-04-06 mail gtest-unittest-api_test - fix warning in clang build
2020-03-28 arthur.j.odwyer Replace the last instance of `throw()` with `noexcept`. NFC.
2020-03-28 arthur.j.odwyer Fix a typo in .travis.yml
2020-03-21 ngompa13 Ensure that gtest/gmock pkgconfig requirements specify version

Roll third_party/re2/ ac65d4531..a5c78ae3e (1 commit)

google/re2@ac65d45...a5c78ae

$ git log ac65d4531..a5c78ae3e --date=short --no-merges --format='%ad %ae %s'
2020-04-19 junyer Use 64-bit integers for the BitState bitmap.

Roll third_party/spirv-cross/ 54658d625..f38cbeb81 (4 commits)

KhronosGroup/SPIRV-Cross@54658d6...f38cbeb

$ git log 54658d625..f38cbeb81 --date=short --no-merges --format='%ad %ae %s'
2020-04-20 post MSL: Allow removing clip distance user varyings.
2020-04-18 godlike Reflection: Add specialization constant name
2020-04-15 cdavis MSL: Force disabled fragment builtins to have the right name.
2020-04-15 cdavis MSL: Only disable output variables in fragment shaders.

Roll third_party/spirv-tools/ ca57515..61b7de3 (10 commits)

KhronosGroup/SPIRV-Tools@ca57515...61b7de3

$ git log ca57515..61b7de3 --date=short --no-merges --format='%ad %ae %s'
2020-04-15 stevenperron Remove unreachable code. (KhronosGroup#3304)
2020-04-15 afdx spirv-fuzz: Fix to outliner (KhronosGroup#3302)
2020-04-14 afdx spirv-fuzz: Do not outline regions that produce pointer outputs (KhronosGroup#3291)
2020-04-14 afdx spirv-fuzz: Handle OpRuntimeArray when replacing ids with synonyms (KhronosGroup#3292)
2020-04-14 afdx spirv-fuzz: Handle image storage class in donation (KhronosGroup#3290)
2020-04-14 afdx spirv-fuzz: Respect rules for OpSampledImage (KhronosGroup#3287)
2020-04-14 afdx spirv-fuzz: Fix comment. (KhronosGroup#3300)
2020-04-14 stevenperron Sampled images as read-only storage (KhronosGroup#3295)
2020-04-14 alanbaker Remove implicit fallthrough (KhronosGroup#3298)
2020-04-14 stevenperron Add tests for recently added command line option (KhronosGroup#3297)

Created with:
  roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-perron s-perron s-perron approved these changes

Assignees

@alan-baker alan-baker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation Issue - Implicit-fallthrough
2 participants
@alan-baker @s-perron