Avoid maintaining a list of all operating systems by hand. #5467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dneto0
approved these changes
Feb 7, 2024
auto-merge was automatically disabled
February 12, 2024 20:02
Pull request was closed
s-perron
pushed a commit
to s-perron/SPIRV-Tools
that referenced
this pull request
Nov 12, 2024
|
I cannot merge because the formating test failed, and the PR was never updated to fix that. I cannot write to the branch to update the PR myself. I've opened a new PR to get this done. |
s-perron
added a commit
that referenced
this pull request
Nov 12, 2024
See #5467 Co-authored-by: Patrick Welche <prlw1@cam.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My standard issue unix system is not supported. Rather than add yet another #define which is only used in one place to mean "not windows", g/c the hand maintained list of operating system names.