Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and deprecate "execution_capabilities" #625

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Sep 19, 2024

  1. Clarify and deprecate "execution_capabilities"

    We had a customer bug report about the behavior of
    `info::device::execution_capabilities` for non-OpenCL devices.  It turns
    out that the spec isn't clear about this.  This PR clarifies that an
    exception should be thrown, which is consistent with our behavior for
    `info::device::profile` and `info::device::preferred_interop_user_sync`,
    which are also inherited from OpenCL.  Another option would be to return
    an empty vector, so we could debate that if people think that's better.
    
    I also think we should deprecate this query, which is consistent with
    the other queries that are specific to the OpenCL backend.  This PR
    deprecates the query in SYCL-NEXT, though I would also be open to
    retroactively deprecating it in SYCL 2020 with the rationale that we
    deprecated the other OpenCL-specific queries and simply forgot this one.
    gmlueck committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5b8c4bc View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Deprecate in SYCL 2020 instead

    The WG decided to deprecate this in SYCL 2020 instead.
    gmlueck committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0e41496 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e49d70c View commit details
    Browse the repository at this point in the history