Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to ray tracing samples broken #903

Closed
SaschaWillems opened this issue Feb 9, 2024 · 0 comments · Fixed by #905
Closed

Links to ray tracing samples broken #903

SaschaWillems opened this issue Feb 9, 2024 · 0 comments · Fixed by #905
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@SaschaWillems
Copy link
Collaborator

While fixing #898 and reworking how samples listings are generated for the documentation site, I noticed that the links to some of the ray tracing samples are broken. Probably because they have been renamed some time ago.

I'll try to fix this.

@SaschaWillems SaschaWillems added the documentation Improvements or additions to documentation label Feb 9, 2024
@SaschaWillems SaschaWillems self-assigned this Feb 9, 2024
SaschaWillems added a commit that referenced this issue Feb 9, 2024
marty-johnson59 pushed a commit that referenced this issue Feb 26, 2024
* Include related extension list instead of linking to it (link was broken anyway)

* Different content depending on generator

* Reworking things

List of examples in subfolder readme
This is then included in tioplevel sample listing instead
Paths need to be adjusted via attributes to make it work for both

* Fix links to ray tracing samples #903

* Fix xref paths

Makes xrefs works both on the separate sample list as well as the page including it
Refs #898

* Fix links to ray tracing samples

Refs #903

* Add samples listing to docs navigation

* Move api samples listing into separate readme

Include in main listing

* Added readme for general samples folder

Include in main listing

* Add samples listing to docs navigation

* Move tooling and performance samples listing into separate readme

Include in main listing

* Update pull request template

* Remove link to pull request template

Didn't work in github either, and makes no sense
People will see that template when they actually do a PR against the repo

* Add link to framework components

Fix linkage for framework core

* Fix link to debug utils sample

* Add a stub readme for the docs folder

* Fix broken links

Refs #824

* Fix broken image links

Refs #824

* Removed unnecessary paragraph

PRs are created via github anyway, and this automatically uses the PR template
No need to mention it explicitly

* Fix copyright

* Fix copyright (again...)

* Fix typo
asuessenbach pushed a commit to asuessenbach/Vulkan-Samples that referenced this issue Feb 27, 2024
* Include related extension list instead of linking to it (link was broken anyway)

* Different content depending on generator

* Reworking things

List of examples in subfolder readme
This is then included in tioplevel sample listing instead
Paths need to be adjusted via attributes to make it work for both

* Fix links to ray tracing samples KhronosGroup#903

* Fix xref paths

Makes xrefs works both on the separate sample list as well as the page including it
Refs KhronosGroup#898

* Fix links to ray tracing samples

Refs KhronosGroup#903

* Add samples listing to docs navigation

* Move api samples listing into separate readme

Include in main listing

* Added readme for general samples folder

Include in main listing

* Add samples listing to docs navigation

* Move tooling and performance samples listing into separate readme

Include in main listing

* Update pull request template

* Remove link to pull request template

Didn't work in github either, and makes no sense
People will see that template when they actually do a PR against the repo

* Add link to framework components

Fix linkage for framework core

* Fix link to debug utils sample

* Add a stub readme for the docs folder

* Fix broken links

Refs KhronosGroup#824

* Fix broken image links

Refs KhronosGroup#824

* Removed unnecessary paragraph

PRs are created via github anyway, and this automatically uses the PR template
No need to mention it explicitly

* Fix copyright

* Fix copyright (again...)

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant