-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No way to access instance from samples anymore #985
Labels
framework
This is relevant to the framework
Comments
19 tasks
As this is blocking me with #945 I'll try to fix in in that PR. |
SaschaWillems
added a commit
to SaschaWillems/Vulkan-Samples
that referenced
this issue
Mar 15, 2024
jeroenbakker-atmind
pushed a commit
to jeroenbakker-atmind/Vulkan-Samples
that referenced
this issue
Mar 27, 2024
* Added new shader debzgprrintf sample Work-in-progress * Note on descriptor size Minor cleanup * Display shaderdebutprintf output in UI * Proper extension structure chaining * Restructure code Use VK 1.2 to avoid a bug with recent Vulkan SDKs * Minor adjustments * Use VK 1.1, clean up messages for UI display * Enable instance extensions * Started working on documentation/tutorial * Fixed link * Minor reordering Easier to document * Tutorial fpr shader printf * Update tutorial * Code adjustments based on review * Clang-format... * Add new argument to custom instance creation so that extensions enabled in a sample will be marked as enabled in the instance class This is required to make other parts of the framework properly work with samples that do custom instance creation * Add function to check if sample has a valid instance Fixes KhronosGroup#985 * Adjust to recent framework changes * Doc fix * Typo * Add sample to cmake ordered list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With #910 some public members were moved to private and can now only be accessed via functions, e.g.
has_device()
instead ofdevice
.But it looks like there is no way to access the instance anymore. There is no
has_instance()
, but I need to access it for my shader debug printf sample like this:The text was updated successfully, but these errors were encountered: