Shapekeys names

[Lexpartizan]

Shapekeys exported named like "Morph 0".
With glTF-Blender-Exporter i can myself name to shapekeys. Its very convenient.

[donmccurdy]

FYI, glTF-Blender-Exporter accomplished this by setting mesh.extras.targetNames on the mesh instance:

https://github.com/KhronosGroup/glTF-Blender-Exporter/blob/7933fbfdd80628875910c5da36fd28e40474fb43/scripts/addons/io_scene_gltf2/gltf2_generate.py#L1511

glTF has no proper mechanism for naming morph targets, but this workaround is accepted in a few tools.

[donmccurdy]

^Probably the importer could use the same properties.

[Lexpartizan]

Thanks for the reply. I'm trying to make Makehuman models into a ingame character generator for Godot. And it turned out about 200 shape keys. Without names, it's a nightmare.
glTF-Blender-Exporter has some errors when exporting.
Animated characters not good. Some of the verticles (around 5 pieces from 14 000), standing to the random side. In the blender all fine. The weights are painted correctly.
glTF-Blender-IO work good, all verticles in their places. But can't naming shapekeys.
Sorry for my english.

[donmccurdy]

For sure! I agree with this feature request, I'm just adding more information for others to weigh in. :)

[scurest]

@Lexpartizan, here's a temporary workaround:

Before exporting, put this in the text editor and run it

import bpy
for m in bpy.data.meshes:
    target_names = [kb.name
        for kb in (m.shape_keys.key_blocks if m.shape_keys else [])
        if kb != kb.relative_key]
    if target_names:
        m['targetNames'] = target_names

then when you export make sure the General > Custom Properties box is ticked.

[Lexpartizan]

@Lexpartizan, here's a temporary workaround:

Before exporting, put this in the text editor and run it
then when you export make sure the General > Custom Properties box is ticked.

Thank you very much, it helped me a lot!

[julienduroure]

OK, added it on my TODO list for importer

[julienduroure]

Importer can now read extras data to name shapeKeys ( b3a78e0 )

[scurest]

@julienduroure 👍
Do you think the extras.targetNames property should take precedence over getting the names from the accessors in the first primitive's morph targets?

[julienduroure]

@scurest Seems extras.targetNames is already used in some other few tools.
I am ok to change it if there are some more used conventions

[scurest]

No, what I mean is that the importer already uses those accessor names to set keyblock names

glTF-Blender-IO/addons/io_scene_gltf2/blender/imp/gltf2_blender_mesh.py

Lines 170 to 179 in b3a78e0

	# set default weights for shape keys, and names
	if pymesh.weights is not None:
	for i in range(max_shape_to_create):
	if i < len(pymesh.weights):
	if gltf.shapekeys[i] is None: # No default value if shapekeys was not created
	continue
	obj.data.shape_keys.key_blocks[gltf.shapekeys[i]].value = pymesh.weights[i]
	if gltf.data.accessors[pymesh.primitives[0].targets[i]['POSITION']].name is not None:
	obj.data.shape_keys.key_blocks[gltf.shapekeys[i]].name = \
	gltf.data.accessors[pymesh.primitives[0].targets[i]['POSITION']].name

and since it does this after it sets from extras.targetNames, the accessor names currently take priority over extras.targetNames. Do you think it should be the other way around?

[julienduroure]

Ah, you're right, my test cases didn't have default weights for shape keys, so it was not overwritten. Will change it

[tlf30]

Hello, I am wondering on the status of getting this in the exporter. I would really appreciate having this functionality built into the blender 2.80 exporter.
Also, @scurest thank you for the work around script.

[julienduroure]

Importer part: targetNames has now priority in any cases

[imgntn]

could also really use the ability to export shape key names, preferably without the user having to run a script in blender first! :) thanks for the great work

[donmccurdy]

I'll work on exporter implementation.

[donmccurdy]

Opened #491, tests and/or reviews welcome. :)