Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLSL: emit OpLoopMerge Unroll for HLSL [unroll] #836

Closed
danginsburg opened this issue Apr 13, 2017 · 4 comments
Closed

HLSL: emit OpLoopMerge Unroll for HLSL [unroll] #836

danginsburg opened this issue Apr 13, 2017 · 4 comments

Comments

@danginsburg
Copy link
Contributor

I believe that currently [unroll] in the HLSL does not result in OpLoopMerge Unroll in the SPIR-V. Please add support for this, it is a feature relied upon by a lot of HLSL for performance.

@gwihlidal
Copy link
Contributor

This is definitely a critical optimization for us, as well

@johnkslang
Copy link
Member

This is listed in #362, where I have bumped it to the top of the list (reflecting priority order).

The following is outside the scope of glslang, but I trust you are also lobbying IHVs to respect the SPIR-V hints for this?

@ghost
Copy link

ghost commented Apr 15, 2017

I wonder if IHVs may often unroll a loop even without an explicit hint.

@ghost
Copy link

ghost commented Apr 28, 2017

John, definitely want those hints to work in GLSL source as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants