ci: Add continuous_integration dependency #3785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-lunarg
commented
Nov 5, 2024
spencer-lunarg
commented
Nov 5, 2024
spencer-lunarg
commented
Nov 5, 2024
|
I don't think this will add very much value: CI jobs mostly succeed, and this just adds latency to every single run. I think it would be better to prune the ci matrix instead, the finding about "gcc" on macos will certainly help us a lot with that. |
https://github.com/KhronosGroup/glslang/actions/workflows/continuous_integration.yml?query=is%3Afailure there have been 137 failure and 531 successes (so that is a 20% failure rate) is the latency something you find that would honestly be a bottleneck, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In effort to reduce the number of limit KhronosGroup minutes we share across repos, this adds dependency to the Continuous Integration CI to only expensive jobs once quicker/smaller jobs run first