Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node versions? #17

Open
chicoxyzzy opened this issue Aug 13, 2018 · 7 comments
Open

Add node versions? #17

chicoxyzzy opened this issue Aug 13, 2018 · 7 comments

Comments

@chicoxyzzy
Copy link

It could be useful to have electron-to-nodejs versions also

@Kilian
Copy link
Owner

Kilian commented Aug 14, 2018

It wouldn't be hard to make this with the existing code, but do you have any specific use-case in mind?

@chicoxyzzy
Copy link
Author

chicoxyzzy commented Aug 14, 2018

That data could be used for specific native modules builds for Electron (some V8 bindings could be deprecated or could break in minor versions of Node/Electron, for example Utf8Value)

@Kilian
Copy link
Owner

Kilian commented Aug 14, 2018

https://github.com/electron/electron-rebuild already does that though?

@chicoxyzzy
Copy link
Author

Not exactly that but kind of, yes. This just one of potential use-cases

@chicoxyzzy
Copy link
Author

chicoxyzzy commented Aug 14, 2018

Not exactly that but kind of, yes.

Hm, actually no. What I'm talking about is V8 API changes, electron-rebuild is project for electron apps but not for native modules. Native modules could be prebuilt to have binaries for different Electron versions. Use cases are different

@anaisbetts
Copy link

anaisbetts commented Aug 16, 2018

That data could be used for specific native modules builds for Electron (some V8 bindings could be deprecated or could break in minor versions of Node/Electron, for example Utf8Value)

Hi, I'm the original author of electron-rebuild. While this initially seems like it'd be useful to avoid rebuilds, Electron is different enough in subtle dumb ways from node.js that binaries built against system node.js often don't work in Electron, even if NODE_MODULE_VERSION is identical :-/ So, until someone is actually gonna use this mapping in software, I'd just hold off on it, it's not as useful as one would think.

@Airkro
Copy link

Airkro commented Apr 23, 2019

This feature is obviously useful. Even if it is not related to electron-rebuild.

Because this package is used in Browserslist, and people use webpack/rollup/parcel/babel/autoprefixer/whatever.

See https://webpack.js.org/configuration/target#string, It provides electron-main and electron-renderer as output.target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants