Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error replies, improve header marshalling, marshal all header fields #118

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

MaxVerevkin
Copy link
Contributor

@MaxVerevkin MaxVerevkin commented Mar 19, 2024

Fixes #117

@MaxVerevkin
Copy link
Contributor Author

I think marshal_header_field may be improved or replaced with something different, because 1) as it is, it requires a few technically unnecessary clones - for destination, interface, member, error_name etc. 2) it is always called with a known variant of HeaderField, so the match is sort of useless (maybe it is optimized out if marshal_header_field is inlined?). A marshal_header_somthing for each field wouldn't be too bad, right?

@KillingSpark
Copy link
Owner

Thanks for all the code review! I'll take a look soon, right now life is pretty busy. Shouldn't be too long though

@KillingSpark KillingSpark mentioned this pull request Mar 21, 2024
3 tasks
@MaxVerevkin MaxVerevkin changed the title Fix error replies Fix error replies, improve header marshalling, marshal all header fields Mar 23, 2024
@KillingSpark KillingSpark merged commit babb098 into KillingSpark:master Apr 3, 2024
4 checks passed
@MaxVerevkin MaxVerevkin deleted the errors branch April 3, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all header fields are marshalled
2 participants