Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that serials are not zero #121

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

MaxVerevkin
Copy link
Contributor

From the spec:

2nd UINT32 - The serial of this message, used as a cookie by the
sender to identify the reply corresponding to this request. This must
not be zero.

@MaxVerevkin
Copy link
Contributor Author

CI failure is related to the recent Rust release, not this PR.

From the spec:
> 2nd UINT32 - The serial of this message, used as a cookie by the
> sender to identify the reply corresponding to this request. This must
> not be zero.
@KillingSpark
Copy link
Owner

Good catch!

@KillingSpark KillingSpark merged commit f7dbe26 into KillingSpark:master Mar 22, 2024
3 of 4 checks passed
@MaxVerevkin MaxVerevkin deleted the nonzeroserial branch March 22, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants