Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure on MacOS using podman #90

Closed
humblehacker opened this issue Jan 6, 2023 · 10 comments · Fixed by #91
Closed

Build failure on MacOS using podman #90

humblehacker opened this issue Jan 6, 2023 · 10 comments · Fixed by #91

Comments

@humblehacker
Copy link
Contributor

Error: preparing container d3ed7931ce28a2b3f8dccb090151f120c89435662bf43e646923c88f7c167449 for attach: lsetxattr Adv360-Pro-ZMK/config/adv360_left.keymap: operation not supported

The changes in PR #58 are the culprit. After reverting locally, I'm able to build successfully.

For reference: containers/podman-compose#509

@ReFil
Copy link
Collaborator

ReFil commented Jan 12, 2023

Thanks for bringing this to my attention, will investigate

@ReFil
Copy link
Collaborator

ReFil commented Jan 12, 2023

Would you be able to test my PR? I dont have a mac to test on

@kibner
Copy link

kibner commented Jan 13, 2023

Would you be able to test my PR? I dont have a mac to test on

I have an M2 MBA on Ventura 13.1 and the PR still doesn't work. I ran make clean and then make. This is my error:

STEP 9/9: CMD ["./build.sh"]
COMMIT zmk
--> deed133ce29
Successfully tagged localhost/zmk:latest
deed133ce29b5c4f550a8a7dd2c2279c77b14f51865d30a4f28b72b67b0c5918
/opt/homebrew/bin/podman run --rm -it --name zmk \
                -v /Users/kibner/src/Adv360-Pro-ZMK/firmware:/app/firmware:z \
                -v /Users/kibner/src/Adv360-Pro-ZMK/config:/app/config:ro,z \
                -e TIMESTAMP=20230113202756 \
                zmk
Error: preparing container 24c739ca68cf1ba4724e869dc56491774750e777a4542628153483c298ebfa34 for attach: lsetxattr /Users/kibner/src/Adv360-Pro-ZMK/firmware: operation not supported
make: *** [all] Error 126

@ReFil
Copy link
Collaborator

ReFil commented Jan 13, 2023

can you put "uname" into terminal and post what you get from the terminal please?

@kibner
Copy link

kibner commented Jan 13, 2023

can you put "uname" into terminal and post what you get from the terminal please?

kibner@Kibners-MacBook-Air Adv360-Pro-ZMK % uname
Darwin

e: Also, I tested basically undoing the changes in PR #58 and I was able to successfully build the firmware. So, I can definitely confirm that with the OP, too.

@ReFil
Copy link
Collaborator

ReFil commented Jan 13, 2023

Thanks for doing that for me. i'm trying to have it detect the OS and remove those SELinux params appropriately, i'll fiddle a bit more and let you know

@ReFil
Copy link
Collaborator

ReFil commented Jan 13, 2023

Please try it again, the uname command adds a sneaky bit of whitespace in that has to be explicitly removed

@kibner
Copy link

kibner commented Jan 13, 2023

Please try it again, the uname command adds a sneaky bit of whitespace in that has to be explicitly removed

It works!

@ReFil
Copy link
Collaborator

ReFil commented Jan 18, 2023

@humblehacker have you had the opportunity to test the changes i've made? it'd be much appreciated if you were able to confirm whether or not they solve the issue

@humblehacker
Copy link
Contributor Author

@ReFil Sorry for the late reply, and thanks for the fix. I checked out your branch and was able to successfully build!

@ReFil ReFil closed this as completed in #91 Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants