Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For KCL generation from create_text_to_cad should require bool and not str(bool) #364

Open
r-barton opened this issue Jan 28, 2025 · 1 comment
Open

For KCL generation from create_text_to_cad should require bool and not str(bool) #364

r-barton opened this issue Jan 28, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@r-barton
Copy link

In the type hinting for create_text_to_cad the kcl argument has expected type bool or None, however the argument actually needs a string of "true" or "false". We should fix this so that a python bool type will work.

Image
@r-barton r-barton added the bug Something isn't working label Jan 28, 2025
@r-barton
Copy link
Author

kittycad.py/kittycad/api/ml/create_text_to_cad.py

Line 94 in 1201ae0

kcl: Optional[bool] = None,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@r-barton