Make sure stable artifact IDs are in all variants KclValue
type
#5186
Labels
dev
Issues related to development of the app.
KclValue
type
#5186
#4442 requires more information from operations than just source ranges. After a discussion with @jtran, we decided that passing through the real
KclValue
for each of an operation's arguments should give us enough information to populate the command palette for most cases of edit flows for operations generically, thereby solving our "missing representation" problem for the time being.The issue right now is that our
KclValue
has some instances where the original artifact ID for an operation is overwritten within the Rust code. @jtran and I couldn't figure out why this was the case, and had to guess that this is to uphold something about the inheritance of IDs in the engine from plane to sketch to sweep ("sweep" in the generic sense). This area of code is worth revisiting elsewhere, but this issue just asks that instead of overwriting the original artifact ID, that we shift it over to some new key on thoseKclValue
s that currently have code that mutates it. That way frontend code (like the feature tree's operation selection and edit code) can derive artifact IDs from theKclValue
s.The text was updated successfully, but these errors were encountered: