Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implementing the 'shown' and 'hidden' events to facilitate animations #649

Closed
5ulo opened this issue Mar 21, 2024 · 2 comments
Closed

Comments

@5ulo
Copy link

5ulo commented Mar 21, 2024

This is more like feature request. As a BS5 user I'm used to use their events show, shown, hide, hidden which is perfect in some cases.
show - fires immediately
shown - fires after show animation ends
hide - fires immediately
hidden - when the hide event ends
The last two are a good way to get proper fade-out to work as we can animate on hide and display: none; on hidden.

@KittyGiraudel KittyGiraudel changed the title Event 'showing', 'hidding' Consider implementing the 'shown' and 'hidden' events to facilitate animations Mar 22, 2024
@KittyGiraudel
Copy link
Owner

Decent ask. Development has slowed down on the library though, so not sure I’ll get around to it.

@KittyGiraudel
Copy link
Owner

So I’m thinking about it and I don’t quite know how that would work. a11y-dialog doesn‘t deal with animations at all. I guess it could fire an event at the beginning of the show method (see #696), and one at the end of the show method, but ultimately they’d fire essentially at the same time since the methods are synchronous.

If you have a prototype or more info, I’m happy to consider it but in the current state, I don’t know how this library would implement something like this. Therefore I’ll be closing it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants