Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dist folder from git history #374

Merged

Conversation

mxmason
Copy link
Contributor

@mxmason mxmason commented Jul 1, 2022

Summary

Does as it says on the tin. This moves the d.ts and js source files into a src directory, as well, just to make input/output a little easier.

Stage one of work discussed in #373

@mxmason
Copy link
Contributor Author

mxmason commented Jul 1, 2022

Oops! I know what I messed up. One sec.

@mxmason
Copy link
Contributor Author

mxmason commented Jul 1, 2022

Hm. I apologize, @KittyGiraudel, I don't know why Cypress isn't working in CI. It works fine for me locally. My last commit was to make sure that the fixture html files reference the a11y-dialog script in the fixtures folder, and that too works on my machine.

@KittyGiraudel
Copy link
Owner

Same problem here. Works fine locally, not on CI. I’m investigating.

@KittyGiraudel
Copy link
Owner

KittyGiraudel commented Jul 1, 2022

@mxmason Ah! I think I got it. Up until now, we had dist files in the repository, so that was fine. But now that they have been removed, it means we need to build them as part of our testing setup in main.yml.

name: Tests
on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main
jobs:
  cypress-run:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v2

      - name: Cypress
        uses: cypress-io/github-action@v2
        with:
          config-file: ./cypress.config.js
-         start: npm run serve
+         start: npm run build && npm run serve
          wait-on: 'http://localhost:5000'

@mxmason
Copy link
Contributor Author

mxmason commented Jul 1, 2022

Aha, I was just coming to say that! We could also change the build script in the package file to do build && serve, if you wanted. I had that in my original PR I think

@KittyGiraudel
Copy link
Owner

KittyGiraudel commented Jul 1, 2022

Actually the clean way might be to use the build option:

name: Tests
on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main
jobs:
  cypress-run:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v2

      - name: Cypress
        uses: cypress-io/github-action@v2
        with:
          config-file: ./cypress.config.js
+         build: npm run build
          start: npm run serve
          wait-on: 'http://localhost:5000'

@KittyGiraudel
Copy link
Owner

Heck yeah. Let’s go! ⭐

@KittyGiraudel KittyGiraudel merged commit 031ba60 into KittyGiraudel:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants