-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dist folder from git history #374
Remove dist folder from git history #374
Conversation
Oops! I know what I messed up. One sec. |
Hm. I apologize, @KittyGiraudel, I don't know why Cypress isn't working in CI. It works fine for me locally. My last commit was to make sure that the fixture html files reference the |
Same problem here. Works fine locally, not on CI. I’m investigating. |
@mxmason Ah! I think I got it. Up until now, we had dist files in the repository, so that was fine. But now that they have been removed, it means we need to build them as part of our testing setup in name: Tests
on:
push:
branches:
- main
pull_request:
branches:
- main
jobs:
cypress-run:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Cypress
uses: cypress-io/github-action@v2
with:
config-file: ./cypress.config.js
- start: npm run serve
+ start: npm run build && npm run serve
wait-on: 'http://localhost:5000' |
Aha, I was just coming to say that! We could also change the build script in the package file to do build && serve, if you wanted. I had that in my original PR I think |
Actually the clean way might be to use the build option: name: Tests
on:
push:
branches:
- main
pull_request:
branches:
- main
jobs:
cypress-run:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Cypress
uses: cypress-io/github-action@v2
with:
config-file: ./cypress.config.js
+ build: npm run build
start: npm run serve
wait-on: 'http://localhost:5000' |
Heck yeah. Let’s go! ⭐ |
Summary
Does as it says on the tin. This moves the
d.ts
andjs
source files into asrc
directory, as well, just to make input/output a little easier.Stage one of work discussed in #373