Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating with Data #7

Closed
collinhundley opened this issue Oct 7, 2016 · 2 comments
Closed

Updating with Data #7

collinhundley opened this issue Oct 7, 2016 · 2 comments

Comments

@collinhundley
Copy link

Line 65 of Updatable.swift - is there any reason data needs to be inout?

public func update(data: inout Data) -> Self?

It makes this method unusable with immutable Data objects. The pointer generated in the closure is immutable so I don't see a reason to force the inout argument.
@billabt
Copy link
Collaborator

billabt commented Oct 7, 2016

I'll take a look. You might be right.

@billabt
Copy link
Collaborator

billabt commented Oct 8, 2016

You were right. Corrected in the latest release. Thanks.

@billabt billabt closed this as completed Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@billabt @collinhundley