Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed _update_path() parameters and parsing dict inside the function #9

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

anshakeel
Copy link
Contributor

HI,
There was a Bug in this Trame based ParaView-Visualizer that it was not able to read any file from data directory. It was throwing the following error when we click to load any file from Data directory:

9feabe7af9d039a8b510e6f0771ffcd5f109fd71
b293a485668b97ae27f2fb62c4117d42ab3a0fbd

According to Error, it seems that _update_path() method was triggered with incomplete arguments because of this the type was considered a unexpected keyword argument.
I simple changed the parameters of _update_path() method and passed only $event as arguments from where this method was triggered and it received a dict . In method body, parsed dict and assigned values to the type and value.

Now it is working, it tested with the following files:

  • Basic ParaView Examples files like bake.e , ge.vtk etc.
  • Custom Reader for reading .db extension files.

Regards,
Ans

@jourdain
Copy link
Collaborator

Hum this is strange as the code before should have worked...
Otherwise that seems reasonable.

@jourdain jourdain merged commit d540974 into Kitware:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants