Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbonmark V1 breaks FIFO for provenance #112

Open
cujowolf opened this issue Feb 6, 2024 · 1 comment
Open

Carbonmark V1 breaks FIFO for provenance #112

cujowolf opened this issue Feb 6, 2024 · 1 comment
Assignees

Comments

@cujowolf
Copy link
Collaborator

cujowolf commented Feb 6, 2024

The current implementation of FIFO logic for provenance records works well for both pooled and native transfers of credits on chain. During the time Carbonmark V1 was live, if multiple listings were made for the same credit, there was not a guaranteed way to treat that pooled balance FIFO based on transfer order.

Say one user listed 2 tons, followed by one listing 8, then the 8 ton listing is purchased first. In the current implementation this would leave the transfer in of 8 tons with a remaining amount of 2, which is incorrect in this case.

@Atmosfearful
Copy link
Contributor

As discussed on a call you will double check if this is still a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants