Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refs #955: deprecate Client::AUTH_* constants and replace them with AuthMethod::AUTH_* const #1036

Merged
merged 5 commits into from
Nov 2, 2021
Merged

refs #955: deprecate Client::AUTH_* constants and replace them with AuthMethod::AUTH_* const #1036

merged 5 commits into from
Nov 2, 2021

Conversation

ipalo
Copy link
Contributor

@ipalo ipalo commented Oct 30, 2021

Contribution for #955

acrobat
acrobat requested changes Oct 31, 2021
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ipalo, thanks for the PR! I've left a few comments on things that should be updated!

lib/Github/AuthMethod.php Outdated Show resolved Hide resolved
lib/Github/Client.php Show resolved Hide resolved
UPGRADE-3.0.md Outdated Show resolved Hide resolved
@ipalo ipalo requested a review from acrobat October 31, 2021 16:14
acrobat
acrobat requested changes Oct 31, 2021
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last minor change that I missed in my previous review, otherwise the PR is good to go!

lib/Github/AuthMethod.php Outdated
*
* @var string
*/
const CLIENT_ID = 'client_id_header';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the public const visibility to the constants in this class.

Suggested change
const CLIENT_ID = 'client_id_header';
public const CLIENT_ID = 'client_id_header';

@acrobat acrobat linked an issue Oct 31, 2021 that may be closed by this pull request
Move AUTH_* constans to dedicated class #955
Closed
@acrobat acrobat merged commit de2f278 into KnpLabs:master Nov 2, 2021
@acrobat
Copy link
Collaborator

acrobat commented Nov 2, 2021

Thanks @ipalo! And congrats on your first contribution! 🎉

@ipalo ipalo deleted the feature/955-deprecate-client-auth-constants branch November 2, 2021 08:58
@ipalo
Copy link
Contributor Author

ipalo commented Nov 8, 2021 •
edited
Loading

Thanks @ipalo! And congrats on your first contribution! 🎉

Hi @acrobat! I noticed the PR hasn't yet been accepted for the Hacktoberfest. Could you unblock it by checking the "accepted" label? Thanks 🙌

@acrobat
Copy link
Collaborator

acrobat commented Nov 9, 2021

@ipalo this should be ok already as the repository has the "hacktoberfest" topic. But I've added the accepted label to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted needs-work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move AUTH_* constans to dedicated class
2 participants
@ipalo @acrobat