Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Apps): use /orgs/ORG/installation #1056

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

ellisio
Copy link
Contributor

@ellisio ellisio commented Mar 1, 2022

According to the documentation this should be /orgs/ORG/installation, not /org/ORG/installation.

Using the singular version results in Bad credentials when using a valid JWT for the GitHub App.

Signed-off-by: Andrew Ellis <awellis89@gmail.com>
@ellisio
Copy link
Contributor Author

ellisio commented Mar 23, 2022

@acrobat Shooting you a ping to see if you have had a chance to look at this. I forked the project and am referencing the fork with Composer. However, I would like to get pointed back to your package directly if possible.

@acrobat acrobat merged commit 4f7d08d into KnpLabs:master Mar 24, 2022
@acrobat
Copy link
Collaborator

acrobat commented Mar 24, 2022

Thank you @ellisio and congrats on your first contribution! 🎉

@ellisio ellisio deleted the patch-1 branch March 28, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants