Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to use generate release notes endpoint #1074

Merged

Conversation

GuySartorelli
Copy link
Contributor

Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the PR @GuySartorelli! Can you check the comment and add a test for the endpoint? Otherwise the PR is good to go! 👌

lib/Github/Api/Repository/Releases.php Outdated Show resolved Hide resolved
@GuySartorelli GuySartorelli force-pushed the pulls/master/add-release-notes-api branch from 41b0a9f to 2354dce Compare July 9, 2022 07:13
@GuySartorelli
Copy link
Contributor Author

Have made the requested change plus added a test.

@GuySartorelli GuySartorelli requested a review from acrobat July 30, 2022 04:05
@acrobat acrobat merged commit 994c5e3 into KnpLabs:master Jul 30, 2022
@acrobat
Copy link
Collaborator

acrobat commented Jul 30, 2022

Thanks @GuySartorelli! And congrats on your first contribution! 🎉

@GuySartorelli GuySartorelli deleted the pulls/master/add-release-notes-api branch July 30, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants