-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to PSR-17 and remove deprecated code #888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add an upgrade file so users have a summary on what was removed/changed and maybe add some info on what packages to remove/replace to move to the psr18 implementation from an existing setup. thanks!
Thanks for the work already @GrahamCampbell! Just a few comments/changes. |
Just rebased and applied changes based on the feedback. |
@acrobat If you do another 2.x -> master merge, I'll rebase this PR again, so that you don't have additional merge conflicts in the authentication class later on. |
Upmerge is done! |
Co-authored-by: Chris Smith <github.com@chris.cs278.org>
Build green now. :) |
Thanks a lot for your work on this @GrahamCampbell! |
No problem. :) |
This PR removes all the deprecated code from the codebase, and switches to PSR-17 which replaces the old PHP HTTP interfaces, just like PSR-18 replaced some of the others (implemented in an earlier PR).