Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken roave/bc-check test #890

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Conversation

acrobat
Copy link
Collaborator

@acrobat acrobat commented Jun 28, 2020

Previously the bc-check was broken due to a changed tag format, which causes an incorrect version/tag to be guessed. This was fixed in 5.0

Detected last minor version: 2.14.0

In Process.php line 256:

  The command "'git' 'rev-parse' '2.14.0'" failed.

  Exit Code: 128(Invalid exit argument)


  Output:
  ================
  2.14.0


  Error Output:
  ================
  fatal: ambiguous argument '2.14.0': unknown revision or path not in the working tree.
  Use '--' to separate paths from revisions, like this:

@GrahamCampbell
Copy link
Contributor

I think this is breaking because the last release had a v on the front by mistake?

@acrobat
Copy link
Collaborator Author

acrobat commented Jun 28, 2020

No not by mistake, I switched to a cli tool to do the merges/releases etc and this tool tags versions with the v prefix. which actually doesn't matter for composer, but the version lib used in roave lost that prefix along the way so an incorrect tag was searched. This was fixed in roave/backward-compatibility-check v5.

@GrahamCampbell
Copy link
Contributor

Ah, right. 👍

@acrobat acrobat merged commit c17e729 into KnpLabs:2.x Jun 29, 2020
@acrobat acrobat deleted the fix-roave-bc-check branch June 29, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants