Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show user by ID #894

Merged
merged 4 commits into from
Jul 4, 2020
Merged

Show user by ID #894

merged 4 commits into from
Jul 4, 2020

Conversation

genintho
Copy link
Contributor

@genintho genintho commented Jul 3, 2020 •
edited
Loading

Revamp of #372 which was abandonned, and following the example of #579

As of 2020, gettting data by ID is still undocumented. I contacted Github support to make sure it could be relied on.

Screen Shot 2020-07-02 at 10 12 15 PM

I have been working with an old application and I have to deal with actions made by user that have changed their login since. The old login are now used by totally different people, which can be problematic.

GrahamCampbell
GrahamCampbell suggested changes Jul 3, 2020
View reviewed changes
lib/Github/Api/User.php Outdated Show resolved Hide resolved
GrahamCampbell
GrahamCampbell approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. 🎉

@genintho genintho mentioned this pull request Jul 3, 2020
Closed
@acrobat acrobat merged commit 1c16592 into KnpLabs:2.x Jul 4, 2020
@acrobat
Copy link
Collaborator

acrobat commented Jul 4, 2020

Thanks @genintho! And congrats on your first contribution! 🎉

acrobat added a commit that referenced this pull request Jul 4, 2020
@acrobat
Merge branch '2.x'
42f5bfb 
* 2.x:
  feature #894 Show user by ID (genintho)
  Don't urlencode integer values
  Fixed incorrect MissingArgumentException parent constructor values
  Removed shadow-cat
  minor #892 Don't use deprecated auth in examples (GrahamCampbell)
  Fix broken roave/bc-check test
  Update branch alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@genintho @acrobat @GrahamCampbell