Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GitHub authentication to GraphQL documentation #927

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

legionth
Copy link
Contributor

@legionth legionth commented Nov 5, 2020

First of all: I love your library, great work 👍

While discovering the official GitHub GraphQL documentation and your repository, I recognized that is currently not possible to communicate with the GraphQL API without authenticating your requests.

I updated the documentation on behalf of GraphQL and added the \Github\Client::authenticate to the code examples. I also added small chapter with some links.

This may help other developers to get started with the GraphQL library 😄

@acrobat acrobat merged commit b79d090 into KnpLabs:2.x Nov 7, 2020
@acrobat
Copy link
Collaborator

acrobat commented Nov 7, 2020

Thanks @legionth! And congrats on your first contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants