Allow PHP8 #934
Merged
Allow PHP8 #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
changed the title
|
No real need to drop PHP 7.1 support? |
|
I did it so I didn't need to support phpunit 7, 8 and 9 to test the whole range of php versions, because of the changes in phpunit 8 and 9 it would not be possible to easily support this (or we had to use something like the symfony phpunit bridge). Also php 7.1 is almost 1 year EOL so this might be a good time to drop support. I plan on still supporting 2.x for a while (which still supports 7.1 but no 8) so users really needing a php 7.1 compatible version can use 2.x. |
Closed
|
Looks fine, after acrobat#2 has been applied. |
acrobat
force-pushed
the
allow-php8
branch
2 times, most recently
from
00d1666
to
50ce136
Compare
…low php8 testing Tweaked minimum versions (by GrahamCampbell) Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also switch the psr cache dev dependency to
symfony/cacheto allow php8 testing