-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[952] doc - Specify lcobucci/jwt version, fix deprecation #953
[952] doc - Specify lcobucci/jwt version, fix deprecation #953
Conversation
a638107
to
438c49f
Compare
Actually, the code should be the following, for compatibility with both 3.4.x and 4.x: $config = Configuration::forSymmetricSigner(
new Sha256(),
LocalFileReference::file('path/to/integration.private-key.pem')
);
$jwt = $config->builder()
->issuedBy($integrationId)
->issuedAt(time())
->expiresAt(time() + 60)
->getToken($config->signer(), $config->signingKey()));
$github->authenticate($jwt, null, Github\Client::AUTH_JWT) |
with the following imports at the top: use Lcobucci\JWT\Configuration;
use Lcobucci\JWT\Signer\Key\LocalFileReference;
use Lcobucci\JWT\Signer\Rsa\Sha256; in place of the other |
Update "integrating with app" example to use lcobucci/jwt 3.4 Fix whitespace formatting update example for compatibility with both 3.4.x and 4.x
438c49f
to
1b853a3
Compare
Closing this PR because I don't know why CI is failing (I did update the head branch with the most recent version of the base) and tbh I've lost interest in figuring it out. |
@amacrobert-meq Sorry I've lost track of this PR, the failing check can be ignored as it is unrelated. So I think we can re-open this PR and have it ready to be merged! |
@acrobat Ok, in that case I'm reopening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good! I've only added 1 change to avoid triggering deprecations otherwise good to merge!
…integration-doc-update * upstream/2.x: Correctly link to github actions docs and fix backlinks Improved bc check bug KnpLabs#979 Deployments: use proper media-type for in_progress/queued, inactive state (staabm)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed the requested changes, all good now.
Thanks @amacrobert-meq! And congrats on your first contribution! 🎉 |
* 2.x: bug #953 [952] doc - Specify lcobucci/jwt version, fix deprecation (amacrobert-meq, acrobat)
Fixes #952