Add accept header for the checks API #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Agares thanks for the PR! Can you change the way the header is set to the "old" way we did this? This will add the header always so there is no need from the end user to call an extra method before using this api endpoint. It will also make it easier to remove the header without BC breaking issues. See the previous PR #924 how to code was before |
|
done! |
acrobat
approved these changes
Feb 8, 2021
|
Thanks @Agares! And congrats on your first contribution! 🎉 |
|
Thanks for merging 🎉 When will a version containing this change be released? |
|
I'm going to check other open PR's in the coming days and release a new version! |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #967.
This PR adds the Accept header back for the Checks API. This is required to make this work on GitHub Enterprise 2.22 (the latest stable version), which still considers this API a preview.