Allow binary content downloads of assets #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
force-pushed
the
binary-asset-downloads
branch
from
ce5275f
to
af16ce7
Compare
acrobat
force-pushed
the
binary-asset-downloads
branch
from
af16ce7
to
dc61c89
Compare
| */ | ||
| public function show($username, $repository, $id) | ||
| public function show($username, $repository, $id, bool $returnBinaryContent = false) |
There was a problem hiding this comment.
I didn't add it because it's fully documented in the typehint 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this to work I also had to change the way the default accept header, previously the header was appended which produced actually an incorrect accept header.
Previously is produced this (this was the same with preview headers being set):
With the default headers plugin being used
Fixes #320