Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix trailing space in SNZB-02P description #5800

Merged
merged 1 commit into from
May 26, 2023
Merged

fix trailing space in SNZB-02P description #5800

merged 1 commit into from
May 26, 2023

Conversation

sjorge
Copy link
Contributor

@sjorge sjorge commented May 25, 2023

Not sure what the pr subject should be with the changes... I don't think it's feat: ... ?

Anyway, the recent PR that added support for SNZB-02P had a training space in the description, this one removes it.

@Koenkk Koenkk merged commit 5900bf0 into Koenkk:master May 26, 2023
@Koenkk
Copy link
Owner

Koenkk commented May 26, 2023

Thanks!

@Koenkk Koenkk mentioned this pull request May 26, 2023
Merged
@sjorge
Copy link
Contributor Author

sjorge commented May 26, 2023

Ah so fix(ignore): because it's a fix and should not end up in the release notes, got it. Will try to remember that for next time.

@sjorge sjorge deleted the patch-16 branch May 26, 2023 07:27
@Koenkk
Copy link
Owner

Koenkk commented May 26, 2023 •
edited
Loading

@sjorge I used fix(ignore): because the device will also be added in the next release, an add and fix in the same release doesn't make sense. If this device was already supported, I would have used fix:. Hope you are liking the new release note generator! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjorge @Koenkk