Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add converter for Halemeier HA-ZBM-MW2 #6098

Merged
merged 10 commits into from
Aug 24, 2023
Merged

Add converter for Halemeier HA-ZBM-MW2 #6098

merged 10 commits into from
Aug 24, 2023

Conversation

guerda
Copy link
Contributor

@guerda guerda commented Aug 21, 2023

Added first version for remote HA-ZBM-MW2
What's not yet working: Battery

Messages are converted and sent to MQTT fine, I don't know yet if they are in the right format. The other Halemeier remote seems to use different expose configurations.

Fixes Koenkk/zigbee2mqtt#18670

src/devices/halemeier.ts Outdated Show resolved Hide resolved
@Koenkk
Copy link
Owner

Koenkk commented Aug 21, 2023

Note to self; after this merge Koenkk/zigbee2mqtt.io#2183

@guerda
Copy link
Contributor Author

guerda commented Aug 21, 2023

I added the actions but have to lint it. Will fix this.

One thing you could help me with please: Is the approach for getting the battery the right one? I copied it from a different device file.
Thanks!

@guerda
Copy link
Contributor Author

guerda commented Aug 21, 2023

Another point: Right now Home Assistant does not show me any entity and it only allows me to trigger on the "on" event (every second click on the "on/off" button).
Is that something is caused by this converter?

@Koenkk
Copy link
Owner

Koenkk commented Aug 22, 2023

  • Battery is OK
  • Do you see an action published on every click in the z2m debug logging?

@guerda
Copy link
Contributor Author

guerda commented Aug 22, 2023

Thanks for the feedback.

Yes, all button clicks create an action in the z2m logging and they all get published on mqtt.

What is missing right now is the integration in Home Assistant, it looks rather empty.

image

@Koenkk
Copy link
Owner

Koenkk commented Aug 22, 2023

It contains everything that is exposed, what would you expect more here? See https://www.zigbee2mqtt.io/guide/usage/integrations/home_assistant.html#via-mqtt-device-trigger-recommended on how to respond to the actions.

@guerda
Copy link
Contributor Author

guerda commented Aug 22, 2023

Thank you for your help. I will check if the battery % reports correctly and will make this branch ready for merging.

Do you prefer rebasing for updating this branch with master?

@Koenkk
Copy link
Owner

Koenkk commented Aug 22, 2023

Do you prefer rebasing for updating this branch with master?

Doesn't matter for me, currently it's fine.

@guerda
Copy link
Contributor Author

guerda commented Aug 22, 2023

It looks like the battery percentage is not working yet. I don't get a percentage pushed and the log shows the following

No converter available for 'HA-ZBM-MW2' with cluster 'genPowerCfg' and type 'attributeReport' and data '{"batteryPercentageRemaining":200}'

It looks like https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/gs.ts#L18
What confuses me is that the device seems to report 200% battery :D

@Koenkk
Copy link
Owner

Koenkk commented Aug 22, 2023

fz.battery was missing, I updated your pr (#6098)

@guerda
Copy link
Contributor Author

guerda commented Aug 22, 2023

Awesome! Thank you. I will check it out tomorrow

@guerda guerda marked this pull request as ready for review August 23, 2023 08:21
@guerda
Copy link
Contributor Author

guerda commented Aug 23, 2023

With fz.battery included, the remaining battery percentage is correctly parsed and broadcast. Thank you!
This PR is now ready to merge from my end.

@Koenkk Koenkk merged commit ccc9591 into Koenkk:master Aug 24, 2023
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Aug 24, 2023

Thanks!

@guerda
Copy link
Contributor Author

guerda commented Aug 24, 2023

Thank you for your help and this awesome project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New device support]: Halemeier remote S-Mitter Basic MultiWhite² 1-Kanal Sender Zigbee (HA-ZBM-MW2)
2 participants