Add basic support for ZigDC #7686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Jun 24, 2024
src/devices/xyzroe.ts
Outdated
| @@ -54,6 +67,22 @@ function getSortedList(source: { [key: string]: number }): string[] { | |||
| return result; | |||
| } | |||
|
|
|||
| const getKey = (object: { [key: string]: number }, value: number) => { | |||
Koenkk
reviewed
Jun 24, 2024
src/devices/xyzroe.ts
Outdated
| @@ -33,6 +33,19 @@ const bindCommandList = { | |||
| 'recall_scene_5': 0x0B, | |||
| }; | |||
|
|
|||
| const switchTypesList = { | |||
| 'switch': 0x00, | |||
| 'single click': 0x01, | |||
There was a problem hiding this comment.
Suggested change
| 'single click': 0x01, | |
| 'single_click': 0x01, |
Koenkk
reviewed
Jun 24, 2024
src/devices/xyzroe.ts
Outdated
| const switchTypesList = { | ||
| 'switch': 0x00, | ||
| 'single click': 0x01, | ||
| 'multi-click': 0x02, |
There was a problem hiding this comment.
Suggested change
| 'multi-click': 0x02, | |
| 'multi_click': 0x02, |
Koenkk
reviewed
Jun 24, 2024
src/devices/xyzroe.ts
Outdated
| 'switch': 0x00, | ||
| 'single click': 0x01, | ||
| 'multi-click': 0x02, | ||
| 'reset to defaults': 0xff, |
There was a problem hiding this comment.
Suggested change
| 'reset to defaults': 0xff, | |
| 'reset_to_defaults': 0xff, |
|
It seems like everything has been fixed. Thank you! |
|
Thanks! Could you also submit a picture for the docs? This can be done by:
Make sure that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic support for ZigDC - Zigbee 6ch DC power meter