fix: Fix Bosch BTH-RA Home Assistant discovery #7720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! 👍 |
Nerivec
reviewed
Jul 1, 2024
| @@ -209,7 +209,7 @@ export interface DefinitionMeta { | |||
| /** | |||
| * Override the Home Assistant discovery payload using a custom function. | |||
There was a problem hiding this comment.
Maybe add a line that informs on where this is executed?
/**
* Override the Home Assistant discovery payload using a custom function.
* Executed right before the payload is passed to `stringify`, before publishing.
*/
There was a problem hiding this comment.
I agree. Maybe mentioning the homeassistant.ts extension explicitly would be helpful?
burmistrzak
approved these changes
Jul 2, 2024
| @@ -209,7 +209,7 @@ export interface DefinitionMeta { | |||
| /** | |||
| * Override the Home Assistant discovery payload using a custom function. | |||
There was a problem hiding this comment.
I agree. Maybe mentioning the homeassistant.ts extension explicitly would be helpful?
| @@ -1354,20 +1354,20 @@ const definitions: Definition[] = [ | |||
| vendor: 'Bosch', | |||
| description: 'Radiator thermostat II', | |||
| meta: { | |||
| overrideHaConfig: (configs) => { | |||
| const entry = configs.findIndex((e) => e.type === 'climate'); | |||
There was a problem hiding this comment.
Much better to just pass a single payload, and not all at once. Like it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for Koenkk/zigbee2mqtt#23075