Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add modern extend for 'text' converter #7846

Merged
merged 6 commits into from
Dec 8, 2024

Conversation

chdefrene
Copy link
Contributor

  • Add modern extend for 'text' converter
  • Convert ELKO 4523430 to use 'text' modern extend

Related fix:

  • Use correct value for 'regulator_mode' for ELKO 4523430 (noticed different readings on the thermostat display vs. Z2M)

@chdefrene
Copy link
Contributor Author

I have not removed this toZigbee converter, since it is used for a device specific rule regarding max allowed characters.

https://github.com/Koenkk/zigbee-herdsman-converters/pull/7846/files#diff-51715221d06da600c3567799bdf03b1c7c25252c45217ff9af22702a4830dc32R43

@Koenkk
Copy link
Owner

Koenkk commented Aug 12, 2024

@chdefrene in order to get rid of the toZigbee converter, we can add an extra argument to the text modernExtend: validate, which is a optional function to validate the input.

@chdefrene
Copy link
Contributor Author

Sorry for the long wait, but I have applied the change now 🙂

@Koenkk Koenkk merged commit 1fb99be into Koenkk:master Dec 8, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Dec 8, 2024

Thanks!

@chdefrene chdefrene deleted the feat/text-modern-extend branch December 9, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants