Update candeo.ts #8142
Merged
Update candeo.ts #8142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Added Candeo LED strip controllers: o C-ZB-LC20-RGBCCT o C-ZB-LC20-RGBW o C-ZB-LC20-RGB o C-ZB-LC20-CCT o C-ZB-LC20-Dim • Fixed incorrect reference for C201 in last update. o A recently submitted change to candeo.ts has been made to match “Candeo Zigbee Dimmer” to the C201. This has caused all C202 devices (a rotary dimmer) to now be presented as the wrong device (a micro module). o We think this is wrong. o The C202 is a far more popular device, therefore we think it makes more sense to match Candeo Zigbee Dimmer to the most popular option, which is C202. • Added Candeo C202.1 Can we please request that @dhc25 and @candeodevelopment are notified if there are future changes to the Candeo devices?
|
I've tried 5 different approaches to formatting these amends. |
|
Thank you @Koenkk |
|
Thanks! That would be nice indeed, @candeodevelopment can you consider this? |
|
@Koenkk yes that would be good, please add both @candeodevelopment and @dhc25 to nitpicks for the candeo.ts file! |
|
@candeodevelopment done! |
Koenkk
added a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Added Candeo LED strip controllers:
o C-ZB-LC20-RGBCCT
o C-ZB-LC20-RGBW
o C-ZB-LC20-RGB
o C-ZB-LC20-CCT
o C-ZB-LC20-Dim
• Fixed incorrect reference for C201 in last update. o A recently submitted change to candeo.ts has been made to match “Candeo Zigbee Dimmer” to the C201. This has caused all C202 devices (a rotary dimmer) to now be presented as the wrong device (a micro module). o We think this is wrong.
o The C202 is a far more popular device, therefore we think it makes more sense to match Candeo Zigbee Dimmer to the most popular option, which is C202.
• Added Candeo C202.1
Can we please request that @dhc25 and @candeodevelopment are notified if there are future changes to the Candeo devices?