Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support device Danfoss Ally Room Sensor 014G2480 #8442

Merged

Conversation

larstobi
Copy link
Contributor

@larstobi larstobi commented Dec 5, 2024

Add support for device Danfoss Ally Room Sensor 014G2480.

Verified working locally.

src/devices/tuya.ts Outdated Show resolved Hide resolved
@Koenkk Koenkk merged commit 8ea8466 into Koenkk:master Dec 5, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Dec 5, 2024

Thanks!

Could you also submit a picture for the docs? This can be done by:

  1. Create a fork by clicking here
  2. Go to the public/images/devices directory, Add file -> Upload files
  3. Upload the files and press Commit changes
  4. Press Contribute -> Open pull request -> update title/description -> Create pull request

Make sure that:

  • The filename is 014G2480.png
  • The size is 512x512
  • The background is transparent (use e.g. Adobe remove background)

@larstobi larstobi deleted the add-device-danfoss-ally-room-sensor-014G2480 branch December 10, 2024 14:12
@larstobi
Copy link
Contributor Author

@Koenkk Just for learning purposes, why did you remove the "Ally Room Sensor" part of the whitelabel name?

@Koenkk
Copy link
Owner

Koenkk commented Dec 11, 2024

I removed it because it was in the model, which should be 014G2480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants