add legrand switch and shutter devices #8006
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Sep 19, 2024
| @@ -697,6 +697,52 @@ const definitions: DefinitionWithExtend[] = [ | |||
| await reporting.onOff(endpoint); | |||
| }, | |||
| }, | |||
| { | |||
| zigbeeModel: ['NLIS - Light switch'], | |||
| model: 'NLIS - Light switch', | |||
There was a problem hiding this comment.
Please use the model numbers written on the device/product page (also use it in Koenkk/zigbee2mqtt.io#3030)
Koenkk
reviewed
Sep 19, 2024
| ota: ota.zigbeeOTA, | ||
| toZigbee: [tzLegrand.led_mode], | ||
| exposes: [eLegrand.ledInDark(), eLegrand.ledIfOn()], | ||
| extend: [deviceEndpoints({endpoints: {l1: 1}}), light({configureReporting: true, endpointNames: ['l1']})], |
There was a problem hiding this comment.
Suggested change
| extend: [deviceEndpoints({endpoints: {l1: 1}}), light({configureReporting: true, endpointNames: ['l1']})], | |
| extend: [light({configureReporting: true})], |
Koenkk
reviewed
Sep 19, 2024
| zigbeeModel: ['NLIS - Double light switch'], | ||
| model: 'NLIS - Double light switch', | ||
| vendor: 'Legrand', | ||
| description: 'Light switch 2 gang Legrand', |
There was a problem hiding this comment.
Remove Legrand from all descriptions, it's already in the vendor.
Koenkk
reviewed
Sep 19, 2024
| ota: ota.zigbeeOTA, | ||
| fromZigbee: [], | ||
| toZigbee: [tzLegrand.shutter_switch_multi_gang, tzLegrand.led_mode], | ||
| extend: [windowCovering({controls: ['lift', 'tilt']})], |
There was a problem hiding this comment.
Suggested change
| extend: [windowCovering({controls: ['lift', 'tilt']})], | |
| extend: [windowCovering({controls: ['lift', 'tilt'], endpointNames: ['l1', 'l2']})], |
Does this work instead of tzLegrand.shutter_switch_multi_gang and .enum('shutter_state', ea.STATE_SET, ['OPEN', 'CLOSE', 'STOP']).withEndpoint('l1'),
|
This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 4 Legrand's devices include: