Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow to set adapter transmit power on startup #1139

Merged
merged 3 commits into from
Aug 4, 2024
Merged

fix: Allow to set adapter transmit power on startup #1139

merged 3 commits into from
Aug 4, 2024

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Aug 3, 2024

@Nerivec probably the ember part is wrong, feel free to update.

@Koenkk Koenkk requested a review from Nerivec August 3, 2024 20:16
Nerivec
Nerivec approved these changes Aug 3, 2024
View reviewed changes
Copy link
Collaborator

@Nerivec Nerivec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Ember part should be:

  • set tx power if mismatching from adapter
  • set tx power during form (saved across reboots, so should be a noop on future restarts as long as not changed)

@Koenkk
Copy link
Owner Author

Koenkk commented Aug 4, 2024

Thanks!

@Koenkk Koenkk merged commit 036a2d5 into master Aug 4, 2024
2 checks passed
@Koenkk Koenkk deleted the fix/transmit-power-on-startup branch August 4, 2024 19:45
@Koenkk Koenkk mentioned this pull request Aug 4, 2024
Merged
@Nerivec Nerivec mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nerivec Nerivec Nerivec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Koenkk @Nerivec