From 93e8a213d36524c20983c304e2c507968b44557d Mon Sep 17 00:00:00 2001
From: mundschenk_at <mundschenk-at@users.noreply.github.com>
Date: Sun, 20 Oct 2024 22:27:04 +0200
Subject: [PATCH] Unify exposed actions for HA

---
 lib/extension/homeassistant.ts | 50 ++++++++++++++++++++++++++++++++--
 1 file changed, 47 insertions(+), 3 deletions(-)

diff --git a/lib/extension/homeassistant.ts b/lib/extension/homeassistant.ts
index a0ddfa3f5b..d23bc90284 100644
--- a/lib/extension/homeassistant.ts
+++ b/lib/extension/homeassistant.ts
@@ -29,6 +29,15 @@ interface Discovered {
     discovered: boolean;
 }
 
+interface ActionData {
+    action: string;
+    button?: string;
+    scene?: string;
+}
+
+const ACTION_BUTTON_PATTERN: string = '^(?<button>[a-z]+)_(?<action>(?:press|hold)(?:_release)?)$';
+const ACTION_SCENE_PATTERN: string = '^(?<action>recall|scene)_(?<scene>[0-2][0-9]{0,2})$';
+
 const SENSOR_CLICK: Readonly<DiscoveryEntry> = {
     type: 'sensor',
     object_id: 'click',
@@ -1153,9 +1162,20 @@ export default class HomeAssistant extends Extension {
                         discovery_payload: {
                             name: endpoint ? /* istanbul ignore next */ `${firstExpose.label} ${endpoint}` : firstExpose.label,
                             state_topic: true,
-                            state_topic_postfix: 'action',
-                            event_types: firstExpose.values.map((v) => v.toString()).filter((v) => !v.includes('*')),
-                            value_template: `{ "event_type": "{{value}}" }`,
+                            event_types: this.prepareActionEventTypes(firstExpose.values),
+
+                            // TODO: Implement parsing for all event types.
+                            value_template:
+                                `{%- set buttons = value_json.action|regex_findall_index(${ACTION_BUTTON_PATTERN.replaceAll(/\?<([a-z]+)>/g, '?P<$1>')}) -%}` +
+                                `{%- set scenes = value_json.action|regex_findall_index(${ACTION_SCENE_PATTERN.replaceAll(/\?<([a-z]+)>/g, '?P<$1>')}) -%}` +
+                                `{%- if buttons -%}\n` +
+                                `   {%- set d = dict(event_type = "{{buttons[1]}}", button = "{{buttons[0]}}_button" -%}\n` +
+                                `{%- elif scenes -%}\n` +
+                                `   {%- set d = dict(event_type = "{{scenes[0]}}", scene = "{{scenes[1]}}" -%}\n` +
+                                `{%- else -%}\n` +
+                                `   {%- set d = dict(event_type = "{{value_json.action}}" ) -%}\n` +
+                                `{%- endif -%}\n` +
+                                `{{d|to_json}}`,
                             ...ENUM_DISCOVERY_LOOKUP[firstExpose.name],
                         },
                     });
@@ -2185,4 +2205,28 @@ export default class HomeAssistant extends Extension {
 
         return bridge;
     }
+
+    private parseActionValue(action: string): ActionData {
+        const buttons = action.match(ACTION_BUTTON_PATTERN);
+        if (buttons && buttons.groups && buttons.groups.action) {
+            return {...buttons.groups, action: buttons.groups.action};
+        }
+
+        const scenes = action.match(ACTION_SCENE_PATTERN);
+        if (scenes && scenes.groups && scenes.groups.action) {
+            return {...scenes.groups, action: scenes.groups.action};
+        }
+
+        const wildcard = action.match( '^(?<action>recall|scene)_*$' );
+        if (wildcard && wildcard.groups && wildcard.groups.action) {
+            logger.debug('Found wildcard action ' + wildcard.groups.action);
+            return {action: wildcard.groups.action, scene: 'wildcard'};
+        }
+
+        return {action};
+    }
+
+    private prepareActionEventTypes(values: zhc.Enum['values']): string[] {
+        return utils.arrayUnique(values.map((v) => this.parseActionValue(v.toString()).action).filter((v) => !v.includes('*')));
+    }
 }